Open
Conversation
7 tasks
absurdlylongusername
requested changes
Apr 24, 2026
Member
absurdlylongusername
left a comment
There was a problem hiding this comment.
Will do proper review later, but for now:
Please add tests. We should not be adding any new functionality to the extractor without adequate testing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR adds support for extracting YouTube live chat messages and exposing them through the existing comments API. When a live stream has regular comments disabled, the extractor now falls back to fetching live chat messages instead.
Changes
CommentsExtractor/CommentsInfo: AddedisLiveChat()flag to distinguish live chat from regular comments.YoutubeCommentsExtractor: AddedfindLiveChatContinuation()andfetchLiveChat()to retrieve live chat via thelive_chat/get_live_chatendpoint.YoutubeLiveChatInfoItemExtractor: New extractor that mapsliveChatTextMessageRendererJSON toCommentsInfoItem, with proper emoji run handling.live_chatpage identifier sogetPage()routes correctly on subsequent extractor instances.Implementation notes
The approach is based on the live chat implementation in PipePipe, adapted to fit the NewPipe Extractor architecture. Key adaptations include:
CommentsInfoItemtype instead of introducing a separate live chat item class.isLiveStreamflag handling to avoid hitting the replay endpoint on fresh extractors.emojiId→shortcuts[]→searchTerms[]→[emoji].Checklist